Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border_width to window coordinates #1969

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Add border_width to window coordinates #1969

merged 3 commits into from
Apr 25, 2024

Conversation

ortango
Copy link
Contributor

@ortango ortango commented Mar 25, 2024

In reference to #1968, this patch is to account to border_width for window coordinates when displaying on the currently focused window (-monitor -2).

Rather then add border width to the window's height and width, we are moving the x, y offsets. 100% of the window would be everything but the border. I looked through xlib manual and icccm, but did not come across a defacto standard for this.

window coors relative to border_width.
Normalize the geometry between reparenting and non- window managers.
@ortango ortango changed the title [WIP] Add border_width to window coordinates Add border_width to window coordinates Mar 27, 2024
@ortango
Copy link
Contributor Author

ortango commented Mar 28, 2024

This changes current behavior for both reparenting and non-reparenting wm's. In both cases 100% x/y offsets and height/width of the window fills the area inside the border/decorations.


so these changes are a little to much. i tested the following wm's : bspwm, dwm, i3 and everything is fine with -m -{2,4}.
testing xmonad (after seeing the xmonad issue/commit) - both 2 and 4 are broken. did not realize that xmonad's ewmh support was optional. after enabling it this is working.

so, this patch also fixes -m -2 for other nonreparenting wm's aside from bspwm.

* remove WM_ROOT_WINDOW_OFFSET
* only translate reparent
@DaveDavenport
Copy link
Collaborator

Thanks!

@DaveDavenport DaveDavenport merged commit 5b9939b into davatorium:next Apr 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants